Store only secondary weight in diacritic table and remove jamo tailoring bit #1978
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…without ignoring default ignorables Default ignorables are not ignored, because doing so would violate the fundamental assumption of the normalizes that every input character produces non-empty output. The expectation is that real NFKC_CaseFold will be implemented by first filtering out default ignorables and then plugging the NFKD_CaseFold data into the upcoming `ComposingNormalizer` code that will turn NFD into NFC and NFKD into NFKC.
Saves 7332 bytes in data size.
…and allow dynamic further shortening in tailorings This makes the action of turning a value read from the table into a `CollationElement` super-simple (and branchless).
hsivonen
added
C-collator
hsivonen
changed the title
|
(I marked this as a draft only because the PR also contains the changesets for #1967. Once that lands, the Files changed view here becomes more useful.) |
hsivonen
requested review from
a team,
sffc,
robertbastian and
Manishearth
as code owners
|
The |
|
Rerun seems to work |
echeran
approved these changes
Jun 6, 2022
|
Thanks. The jamo tailoring stuff was e.g. the removal of the bit getter. |
yzhang1994
pushed a commit
to yzhang1994/icu4x
that referenced
this pull request
Jun 8, 2022
…ring bit (unicode-org#1978) * Store only secondary weight in the diacritic table, make it shorter, and allow dynamic further shortening in tailorings This makes the action of turning a value read from the table into a `CollationElement` super-simple (and branchless). * Remove unused jamo tailoring bit from metadata * Fix clippy lints
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This both simplifies the case that the table is designed for and makes it possible to have non-self-contained CE32 diacritic tailorings.