Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove negate #2060

Merged
merged 13 commits into from
Jun 28, 2022
Merged

Remove negate #2060

merged 13 commits into from
Jun 28, 2022

Conversation

eggrobin
Copy link
Member

@eggrobin eggrobin commented Jun 14, 2022 •
edited
Loading

Replace the FFI negate with a set_sign.

Following up on #2025, part of #1267.

@eggrobin eggrobin mentioned this pull request Jun 15, 2022
Merged
@jira-pull-request-webhook
Copy link

Notice: the branch changed across the force-push!

  • utils/fixed_decimal/src/decimal.rs is different

View Diff Across Force-Push

~ Your Friendly Jira-GitHub PR Checker Bot

@eggrobin eggrobin marked this pull request as ready for review June 28, 2022 12:53
@eggrobin eggrobin requested review from sffc and a team as code owners June 28, 2022 12:53
Manishearth
Manishearth previously approved these changes Jun 28, 2022
View reviewed changes
sffc
sffc previously approved these changes Jun 28, 2022
View reviewed changes
Copy link
Member

@sffc sffc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with one nit to add #[rust_link]

ffi/diplomat/src/fixed_decimal.rs Show resolved Hide resolved
@eggrobin eggrobin dismissed stale reviews from sffc and Manishearth via 0ddd343 June 28, 2022 15:40
@eggrobin eggrobin merged commit 71ab5da into unicode-org:main Jun 28, 2022
samchen61661 pushed a commit to samchen61661/icu4x that referenced this pull request Jul 12, 2022
@eggrobin @samchen61661
Remove negate (unicode-org#2060)
c11c01c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Manishearth Manishearth Manishearth approved these changes

@sffc sffc sffc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@eggrobin @sffc @Manishearth