-
Notifications
You must be signed in to change notification settings - Fork 183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CompactDecimal and ScientificDecimal #2847
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sffc
requested changes
Nov 30, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great start!
sffc
reviewed
Dec 1, 2022
sffc
previously approved these changes
Dec 5, 2022
Please update missing_apis.txt:
Make sure you merge in |
sffc
approved these changes
Dec 5, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Getting back to #1267, where we had decided to add these types.
I have a couple of questions here.
Is this is the right place for these structs?Edit: no it wasn’t, CompactDecimal and ScientificDecimal #2847 (comment).ScientificDecimal
is a lot likeFixedDecimal
; it has the nice property all of its values can be formatted (e.g.,0012.300e+003
would unambiguously be 0012,300×10⁺⁰⁰³ infr-FR
, which, while silly-looking, is well-defined).CompactDecimal
is much messier;1c4
cannot be formatted inen-US
, and arguably neither can1000c6
because of the way CLDR compact decimal data is structured.I think it nevertheless makes sense to use the source number as our input here, because it allows users to have their own rounding logic (something for which there is a use case, and which is very tricky to do with ICU4C; when I needed that, I resorted to counting digits in the formatted output!). However this is not directly usable without also providing the locale-dependent mapping from the magnitude of the source number to the power of ten used in compact notation (in en-US, something like 3↦3, 4↦3, 5↦3, 6↦6, etc.).
I would like to confirm that are aware of that, and that we still want to use
CompactDecimal
as our source format.