Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add top-level testdata crate #296

Merged
merged 1 commit into from
Oct 9, 2020
Merged

Add top-level testdata crate #296

merged 1 commit into from
Oct 9, 2020

Conversation

sffc
Copy link
Member

@sffc sffc commented Oct 3, 2020 •
edited
Loading

This adds a new crate "icu-testdata" with a function returning a data provider that loads from test data. It includes a convenient command for re-generating the test data in a reproducible way.

@sffc sffc self-assigned this Oct 3, 2020
@zbraniecki zbraniecki mentioned this pull request Oct 3, 2020
Closed
@sffc sffc mentioned this pull request Oct 5, 2020
Merged
@coveralls
Copy link

coveralls commented Oct 5, 2020 •
edited
Loading

Pull Request Test Coverage Report for Build b762e06e233af8432a4916b15a45b18b845228ef-PR-296

  • 5 of 147 (3.4%) changed or added relevant lines in 8 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+8.4%) to 74.498%
Changes Missing Coverage Covered Lines Changed/Added Lines %
components/cldr-json-data-provider/src/reader.rs 0 1 0.0%
components/cldr-json-data-provider/src/support.rs 0 1 0.0%
components/cldr-json-data-provider/src/transform/mod.rs 0 1 0.0%
components/cldr-json-data-provider/src/download/cldr_paths_download.rs 0 2 0.0%
resources/testdata/src/metadata.rs 0 44 0.0%
resources/testdata/src/bin/icu4x-gen-testdata.rs 0 93 0.0%
Files with Coverage Reduction New Missed Lines %
components/locale/src/serde/langid.rs 1 88.24%
Totals Coverage Status
Change from base Build c08d490c92c0187ee5504b8505d5fac7387d8675: 8.4%
Covered Lines: 3003
Relevant Lines: 4031
💛 - Coveralls

@sffc sffc force-pushed the testdata branch 2 times, most recently from ef7fe55 to bc54a3d Compare October 8, 2020 00:45
@sffc sffc changed the title Add testdata from CLDR Add top-level testdata crate Oct 8, 2020
@sffc sffc requested a review from zbraniecki October 8, 2020 01:38
@sffc
Copy link
Member Author

sffc commented Oct 8, 2020

This is ready for review. Please let me know where you think this belongs in the directory heirarchy.

@sffc sffc marked this pull request as ready for review October 8, 2020 01:40
@sffc sffc requested a review from a team as a code owner October 8, 2020 01:40
zbraniecki
zbraniecki previously approved these changes Oct 8, 2020
View reviewed changes
Copy link
Member

@zbraniecki zbraniecki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

resources/testdata/src/bin/icu4x-gen-testdata.rs Outdated Show resolved Hide resolved
@jira-pull-request-webhook
Copy link

Notice: the branch changed across the force-push!

  • resources/testdata/Cargo.toml is different
  • resources/testdata/src/bin/icu4x-gen-testdata.rs is different
  • resources/testdata/src/metadata.rs is different

View Diff Across Force-Push

~ Your Friendly Jira-GitHub PR Checker Bot

@jira-pull-request-webhook
Copy link

Notice: the branch changed across the force-push!

  • resources/testdata/src/bin/icu4x-gen-testdata.rs is different

View Diff Across Force-Push

~ Your Friendly Jira-GitHub PR Checker Bot

@jira-pull-request-webhook
Copy link

Notice: the branch changed across the force-push!

  • resources/testdata/src/metadata.rs is different

View Diff Across Force-Push

~ Your Friendly Jira-GitHub PR Checker Bot

@sffc
Adding testdata package.
938f505 
- Includes tooling to re-generate the testdata.
@jira-pull-request-webhook
Copy link

Notice: the branch changed across the force-push!

  • resources/testdata/src/metadata.rs is different

View Diff Across Force-Push

~ Your Friendly Jira-GitHub PR Checker Bot

@sffc sffc requested a review from zbraniecki October 8, 2020 23:54
zbraniecki
zbraniecki approved these changes Oct 9, 2020
View reviewed changes
Copy link
Member

@zbraniecki zbraniecki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm!

@sffc sffc merged commit 52300b8 into master Oct 9, 2020
@sffc sffc deleted the testdata branch October 9, 2020 00:13
This was linked to issues Oct 9, 2020
Multi-layered directory structure #194
Closed
Where to save generated data #227
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zbraniecki zbraniecki zbraniecki approved these changes

Assignees

@sffc sffc

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Where to save generated data Multi-layered directory structure
3 participants
@sffc @coveralls @zbraniecki