Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds aliases between CI, config.toml, and Makefile.toml #376

Merged
merged 10 commits into from
Nov 10, 2020
Merged

Adds aliases between CI, config.toml, and Makefile.toml #376

merged 10 commits into from
Nov 10, 2020

Conversation

sffc
Copy link
Member

@sffc sffc commented Nov 3, 2020 •
edited
Loading

Also adds cargo-all-features, replacing #172.

Fixes #334
Fixes #63
Fixes #139

@coveralls
Copy link

coveralls commented Nov 3, 2020 •
edited
Loading

Pull Request Test Coverage Report for Build f90c9236ba6e669fae492a024307c998c59a972f-PR-376

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 9 unchanged lines in 1 file lost coverage.
  • Overall coverage remained the same at 74.698%
Files with Coverage Reduction New Missed Lines %
components/provider_cldr/src/download/io_util.rs 9 42.19%
Totals Coverage Status
Change from base Build 989bb737ce70a8e1d16bc04c173f09f2eb7779bb: 0.0%
Covered Lines: 3404
Relevant Lines: 4557
💛 - Coveralls

@sffc sffc mentioned this pull request Nov 3, 2020
Closed
@sffc sffc requested a review from echeran November 3, 2020 06:27
@sffc sffc marked this pull request as ready for review November 3, 2020 06:27
@sffc sffc requested review from zbraniecki and a team as code owners November 3, 2020 06:27
@sffc sffc mentioned this pull request Nov 3, 2020
Closed
@sffc sffc mentioned this pull request Nov 3, 2020
Merged
zbraniecki
zbraniecki previously approved these changes Nov 3, 2020
View reviewed changes
Copy link
Member

@zbraniecki zbraniecki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@sffc sffc added this to the Post 0.1 Cleanup milestone Nov 6, 2020
@sffc
Copy link
Member Author

sffc commented Nov 10, 2020

I'm going to merge this to unblock other PRs such as #365 and #381.

@sffc sffc merged commit 4b7a11d into unicode-org:master Nov 10, 2020
@sffc sffc deleted the ci branch November 10, 2020 08:19
@sffc sffc mentioned this pull request Nov 10, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zbraniecki zbraniecki zbraniecki left review comments

@echeran echeran Awaiting requested review from echeran

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Post 0.1 Cleanup
3 participants
@sffc @coveralls @zbraniecki