-
Notifications
You must be signed in to change notification settings - Fork 176
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stub out a components test, and use serde serialization for DateTime options #461
Merged
gregtatum
merged 17 commits into
unicode-org:master
from
gregtatum:datetime-serialization
Feb 8, 2021
Merged
Stub out a components test, and use serde serialization for DateTime options #461
gregtatum
merged 17 commits into
unicode-org:master
from
gregtatum:datetime-serialization
Feb 8, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gregtatum
commented
Jan 22, 2021
Looks like I still have a few CI failures on the features job. I'll take a look at that on Monday. |
Pull Request Test Coverage Report for Build eeb56620c66f56c7d60a0e6f44e53e354be61eef-PR-461
💛 - Coveralls |
I fixed the issue on the build. Since serde is an optional dependency, it might not exist. The conditional is now a bit gross, but it turns into a check for not having the |
sffc
reviewed
Jan 25, 2021
zbraniecki
previously approved these changes
Feb 5, 2021
zbraniecki
approved these changes
Feb 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR stubs out a single test for components. In order to do that, I opted for using serde serialization, as an optional dependency. I took the Cargo.toml approach from #451.
I went ahead, and in this PR, converted over the Style bag's tests to use serde serialization as well.