Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skeleton matching with the components bag #479

Closed

Conversation

gregtatum
Copy link
Member

@gregtatum gregtatum commented Feb 5, 2021

This PR contains work from PR #480, but also implements some of the skeleton matching algorithm. For review, please only consider Part 3.

@coveralls
Copy link

coveralls commented Feb 5, 2021

Pull Request Test Coverage Report for Build e76177bb6c273946b531f99b157af4d1d2042792-PR-479

  • 353 of 592 (59.63%) changed or added relevant lines in 10 files are covered.
  • 4 unchanged lines in 3 files lost coverage.
  • Overall coverage decreased (-0.8%) to 71.862%

Changes Missing Coverage Covered Lines Changed/Added Lines %
components/datetime/src/error.rs 0 1 0.0%
components/datetime/src/fields/length.rs 0 1 0.0%
components/datetime/src/fields/mod.rs 4 11 36.36%
components/datetime/src/provider/helpers.rs 3 16 18.75%
components/datetime/src/pattern/mod.rs 48 62 77.42%
components/provider_cldr/src/transform/dates.rs 28 43 65.12%
components/datetime/src/options/components.rs 71 107 66.36%
components/datetime/src/skeleton.rs 73 117 62.39%
components/datetime/src/fields/symbols.rs 37 88 42.05%
components/datetime/src/provider/mod.rs 89 146 60.96%
Files with Coverage Reduction New Missed Lines %
components/datetime/src/fields/symbols.rs 1 64.21%
components/datetime/src/provider/mod.rs 1 53.09%
components/datetime/src/options/components.rs 2 59.2%
Totals Coverage Status
Change from base Build b15c0b36901095406a67e3620a3d1d0e294b7692: -0.8%
Covered Lines: 5215
Relevant Lines: 7257

💛 - Coveralls

@jira-pull-request-webhook
Copy link

Notice: the branch changed across the force-push!

  • Cargo.lock is now changed in the branch
  • components/datetime/Cargo.toml is now changed in the branch
  • components/datetime/src/error.rs is different
  • components/datetime/src/fields/length.rs is different
  • components/datetime/src/fields/mod.rs is different
  • components/datetime/src/fields/symbols.rs is different
  • components/datetime/src/lib.rs is different
  • components/datetime/src/options/components.rs is different
  • components/datetime/src/options/preferences.rs is no longer changed in the branch
  • components/datetime/src/options/skeleton.json is no longer changed in the branch
  • components/datetime/src/options/style.rs is no longer changed in the branch
  • components/datetime/src/pattern/mod.rs is now changed in the branch
  • components/datetime/src/provider/helpers.rs is different
  • components/datetime/src/provider/mod.rs is different
  • components/datetime/src/skeleton.rs is different
  • components/datetime/tests/datetime.rs is different
  • components/datetime/tests/fixtures/mod.rs is no longer changed in the branch
  • components/datetime/tests/fixtures/structs.rs is no longer changed in the branch
  • components/datetime/tests/fixtures/tests/components.json is different
  • components/provider_cldr/Cargo.toml is now changed in the branch
  • components/provider_cldr/src/transform/dates.rs is different
  • resources/testdata/data/json/dates/gregory@1/ar-EG.json is different
  • resources/testdata/data/json/dates/gregory@1/ar.json is different
  • resources/testdata/data/json/dates/gregory@1/bn.json is different
  • resources/testdata/data/json/dates/gregory@1/ccp.json is different
  • resources/testdata/data/json/dates/gregory@1/en-US-posix.json is different
  • resources/testdata/data/json/dates/gregory@1/en-ZA.json is different
  • resources/testdata/data/json/dates/gregory@1/en.json is different
  • resources/testdata/data/json/dates/gregory@1/es-AR.json is different
  • resources/testdata/data/json/dates/gregory@1/es.json is different
  • resources/testdata/data/json/dates/gregory@1/fr.json is different
  • resources/testdata/data/json/dates/gregory@1/ja.json is different
  • resources/testdata/data/json/dates/gregory@1/ru.json is different
  • resources/testdata/data/json/dates/gregory@1/sr-Cyrl.json is different
  • resources/testdata/data/json/dates/gregory@1/sr-Latn.json is different
  • resources/testdata/data/json/dates/gregory@1/sr.json is different
  • resources/testdata/data/json/dates/gregory@1/th.json is different
  • resources/testdata/data/json/dates/gregory@1/tr.json is different
  • resources/testdata/data/json/dates/gregory@1/und.json is different

View Diff Across Force-Push

~ Your Friendly Jira-GitHub PR Checker Bot

@gregtatum gregtatum force-pushed the date-time-format-options branch from 010402a to bfb62f4 Compare March 2, 2021 19:56
@jira-pull-request-webhook
Copy link

Notice: the branch changed across the force-push!

  • components/datetime/src/pattern/mod.rs is different
  • components/datetime/src/provider/mod.rs is different
  • components/datetime/src/skeleton.rs is different

View Diff Across Force-Push

~ Your Friendly Jira-GitHub PR Checker Bot

@codecov-io
Copy link

Codecov Report

Merging #479 (bfb62f4) into master (b15c0b3) will decrease coverage by 0.98%.
The diff coverage is 59.62%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #479      +/-   ##
==========================================
- Coverage   73.92%   72.94%   -0.99%     
==========================================
  Files         118      119       +1     
  Lines        6396     6981     +585     
==========================================
+ Hits         4728     5092     +364     
- Misses       1668     1889     +221     
Impacted Files Coverage Δ
components/datetime/src/error.rs 0.00% <0.00%> (ø)
components/datetime/src/fields/length.rs 83.33% <0.00%> (ø)
components/datetime/src/lib.rs 100.00% <ø> (ø)
components/datetime/src/provider/helpers.rs 52.83% <18.75%> (-6.12%) ⬇️
components/datetime/src/fields/mod.rs 32.14% <36.36%> (+32.14%) ⬆️
components/datetime/src/fields/symbols.rs 64.21% <42.04%> (-12.49%) ⬇️
components/datetime/src/provider/mod.rs 53.09% <60.95%> (+28.09%) ⬆️
components/datetime/src/skeleton.rs 62.39% <62.39%> (ø)
components/provider_cldr/src/transform/dates.rs 72.03% <65.11%> (-1.03%) ⬇️
components/datetime/src/options/components.rs 59.20% <66.35%> (+42.53%) ⬆️
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b15c0b3...bfb62f4. Read the comment docs.

@gregtatum gregtatum changed the title Experimental date time format options Skeletong matching with the components bag Mar 2, 2021
@gregtatum gregtatum changed the title Skeletong matching with the components bag Skeleton matching with the components bag Mar 2, 2021
Base automatically changed from master to main March 4, 2021 18:40
@gregtatum
Copy link
Member Author

I'm opening a new PR with the latest work. See #587 for the latest.

@gregtatum gregtatum closed this Mar 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants