Migrate time zone and dayperiod fixtures to neo datetime #5411
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sffc
requested review from
Manishearth
and removed request for
zbraniecki and
nordzilla
sffc
commented
Aug 27, 2024
| @@ -652,7 +652,7 @@ | |||
| "GenericNonLocationShort" | |||
| ], | |||
| "fallback_formats": ["LocalizedGmt"], | |||
| "expected": ["GMT"] | |||
| "expected": ["Тролль"] | |||
There was a problem hiding this comment.
The changes in this file appear to be "actual bugs" based on my reading of the spec and the locale data. (They were broken and now they are fixed)
sffc
commented
Aug 27, 2024
| ), | ||
| ]); | ||
|
|
||
| let parsed_pattern = DateTimePattern::try_from_pattern_str(pattern_input).unwrap(); |
There was a problem hiding this comment.
I feel like I deserve a spot bonus for finally getting rid of this terrible pattern override code that's been haunting us for so long
sffc
changed the title
Manishearth
previously approved these changes
Aug 27, 2024
|
Strange, the CI failure doesn't reproduce locally |
|
The PR is passing CI; can I have another approval? Otherwise I might push more commits migrating more tests |
Manishearth
approved these changes
Aug 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1317