Migrate datetime benches to semantic datetime #5464
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sffc
commented
Aug 28, 2024
| @@ -1,48 +1,16 @@ | |||
| [ | |||
There was a problem hiding this comment.
In these JSON files:
- I deleted any tests that were duplicates, either within the same file or in a different file
- I added the semantic skeleton to all remaining tests
- In a small number of cases, I moved the test to a different part of the file to make it easier to see logically what tests were being included
Manishearth
approved these changes
Aug 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1317
I deleted the benches whose only purpose appears to be measuring the difference between
write_to,write_to_string,Display::fmt, andto_string. This would be a fair bit of code to migrate, and it is better done as a bench in the Writeable crate (which we already have).