Don't use 1.x baked data in icu_datetime #5553
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sffc
changed the title
sffc
requested review from
robertbastian,
Manishearth,
zbraniecki and
nordzilla
as code owners
| impl_chinese_date_symbols_v1_marker!(Baked); | ||
| impl_coptic_date_lengths_v1_marker!(Baked); | ||
| impl_coptic_date_symbols_v1_marker!(Baked); | ||
| impl_dangi_date_lengths_v1_marker!(Baked); |
There was a problem hiding this comment.
If this data is not needed anymore, it should be removed from the KEYS array, so they don't get generated anymore. Later, the data markers should also be deleted.
There was a problem hiding this comment.
Not a super interesting milestone, but it's what I was able to finish today and it's landable
Manishearth
approved these changes
Sep 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1317
Not a super interesting milestone, but it's what I was able to finish today and it's landable