Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use script fallback in collator #5743

Merged
merged 2 commits into from
Oct 29, 2024
Merged

Use script fallback in collator #5743

merged 2 commits into from
Oct 29, 2024

Conversation

robertbastian
Copy link
Member

@robertbastian robertbastian commented Oct 29, 2024 •
edited
Loading

Fixes #3867?

@robertbastian robertbastian merged commit 88a1a54 into unicode-org:main Oct 29, 2024
28 checks passed
@robertbastian robertbastian deleted the collf branch October 29, 2024 22:17
sffc
sffc reviewed Nov 2, 2024
View reviewed changes
Copy link
Member

@sffc sffc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems consistent with what we agreed. Does it fix any bugs?

@sffc sffc mentioned this pull request Nov 2, 2024
Closed
@sffc
Copy link
Member

sffc commented Nov 2, 2024

#1964 is an issue to track testing this.

Ideally a change like this would be landed alongside fixes to tests that demonstrate what was fixed by it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sffc sffc sffc left review comments

@Manishearth Manishearth Manishearth approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fallback behavior for extension keywords and auxiliary keys
3 participants
@robertbastian @sffc @Manishearth