Split the UCA checks into their own job, check UCD consistency #562
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
major credit for creative commit messages! |
@robertbastian once told me about a PR on ICU4X that my commit messages tell a story, and that’s definitely the case here (I was testing with the build on push on eggrobin/unicodetools, but the tree was being checked out from unicode-org/unicodetools, so I was running the Python script without my changes…). |
josh-hadley
reviewed
Oct 8, 2023
| @@ -17,9 +17,10 @@ | |||
|
|
|||
|
|
|||
| def main(): | |||
| out_of_source = '--out-of-source' in sys.argv[1:] | |||
There was a problem hiding this comment.
As a reminder for our future selves: if we need to use additional args for this script, we should probably make use of Python's argparse module for robust handling. Not a concern for this PR though.
josh-hadley
approved these changes
Oct 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ucd-and-smoke-tests job will leave an error message in the diff on every file that needs to be regenerated with MakeUnicodeFiles, see https://github.com/unicode-org/unicodetools/pull/562/files/81e0e3708a2e26fe89b46b95b487e44eebc63e67 (scroll to the bottom).
See multiple threads on properties@ and #445 (comment).