[UDD-35] Concurrent Document Extraction Eexample #255
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kellemNegasi
changed the title
3ace
requested changes
Jun 11, 2024
sampila
requested changes
Jun 11, 2024
|
|
||
| // runConcurrent takes the list of input documents and destination output directory and runs the extraction concurrently. | ||
| func runConcurrent(documents []string, outputDir string) { | ||
| res := make(chan map[string]string, 3) |
There was a problem hiding this comment.
Shouldn't this same as document length? like
res := make(chan map[string]string, len(documents))
There was a problem hiding this comment.
Not necessarily. If we are reading as soon as the go routines are writting to the channel a buffer length of 1 is still enough but I made it 3 just to be safe. I think may be i should increase that in case reading side is very slow.
There was a problem hiding this comment.
@sampila Updated. Can you check again?
3ace
approved these changes
Jun 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.