-
-
Notifications
You must be signed in to change notification settings - Fork 110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add explicit dependency on @types/unist
#146
Conversation
We import directly from 'unist', so it should be make an explicit dependency. This ensures we are using the latest version of unist.
cc @wooorm @remcohaszing @ChristianMurphy Should I bump unified's (patch?) version number too, so the change in typing doesn't affect packages depending on the old system? |
Btw @ChristianMurphy @wooorm I'm working through the main unified packages to update I've done a few repos (for the most part, the code doesn't need changing, just the dependencies), but I want to check with you both that I'm doing the correct thing before I go ahead with the others. |
Co-authored-by: Christian Murphy <christian.murphy.42@gmail.com>
This comment has been minimized.
This comment has been minimized.
Thanks @GuiltyDolphin! |
Alright! I'll keep checking through then, but without updating version numbers and just make sure that typings are okay for the latest version of |
@types/unist
Initial checklist
Description of changes
This PR adds the latest version of
@types/unist
an explicit dependency (as we import from it directly).Edit: I notice in the description that dependency on
@types/unist
is suggested for projects using typescript - is there a particular downside to depending on it directly here?