Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make schema and schema component method signatures consistent #139

Closed
cosmicBboy opened this issue Jan 8, 2020 · 2 comments
Closed

Make schema and schema component method signatures consistent #139

cosmicBboy opened this issue Jan 8, 2020 · 2 comments

Comments

@cosmicBboy
Copy link
Collaborator

Currently the SeriesSchemaBase class and subclasses have inconsistent method signatures, which pylint is complaining about, see: #138 (comment)

Need to come up with a solution to make signatures consistent, ideally without breaking the public API.
@mastersplinter mastersplinter mentioned this issue Jan 8, 2020
Closed
15 tasks
@cosmicBboy
Copy link
Collaborator Author

this would be addressed by #153

@cosmicBboy
Copy link
Collaborator Author

fixed by #153

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@cosmicBboy