-
-
Notifications
You must be signed in to change notification settings - Fork 316
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
essential ci fixes and pylint changes #138
Conversation
…educe_pytest_exceptions
…CI_with_pylint_fixes
28e6716
to
1445b4a
Compare
Codecov Report
@@ Coverage Diff @@
## master #138 +/- ##
==========================================
+ Coverage 95.92% 95.95% +0.02%
==========================================
Files 8 8
Lines 442 445 +3
==========================================
+ Hits 424 427 +3
Misses 18 18
Continue to review full report at Codecov.
|
as before - I think codecov failures are false. |
excellent!
I think 5 inputs for functions/methods are quite restrictive and we should stay with option 1, at least for the foreseeable future.
I created a separate task to tackle this issue 139... I do think the |
The Python 3.5 CI process has never worked correctly - the previous mixture of Conda and Pip dependencies caused the Python version to be upgrade to Python 3.7.5 and this can only be seen in the Raw job logs on Travis. This means the current pandera versions are not tested properly for Python 3.5 support - this PR fixes that.
Fixing the CI is complicated because Pylint is currently 2.4.4 but the last version that supports 3.5 is 2.1.1 and that has different linting rules which cause 3.5-specific failures.
This PR:
ci/deps
environment.yml
files closes Switch to environment.yml or remove conda? #130requirements.txt
requirements-dev.txt
which is generated from the baseenvironment.yml
file and not manually maintained.This leaves the following pylint errors where @cosmicBboy I need your input.
There are similar options for each, but with different consequences:
Fixing R0913 too-many-arguments:
messages control
of.pylintrc
messages control
Fixing W0222 signature-differs:
messages control
of.pylintrc
SeriesSchemaBase
Can I also suggest you squash merge this PR with all of the linting fixes into one large commit to ensure a clean commit history: