-
Notifications
You must be signed in to change notification settings - Fork 343
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Nubit modular-indexer-light-sdk verification demo #196
Open
ghost
wants to merge
14
commits into
unisat-wallet:master
Choose a base branch
from
RiemaLabs:nubit
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: MeihaoZuyu <anqur@riema.xyz>
Signed-off-by: MeihaoZuyu <anqur@riema.xyz>
Signed-off-by: MeihaoZuyu <anqur@riema.xyz>
TeriThetha
approved these changes
Oct 29, 2024
TeriThetha
approved these changes
Oct 29, 2024
TeriThetha
approved these changes
Oct 29, 2024
TeriThetha
approved these changes
Oct 29, 2024
TeriThetha
approved these changes
Oct 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi UniSat folks! I'm the developer from the Nubit team. We extended the functionalities of the UniSat Wallet extension (version
v1.3.0
) via integrating Nubit modular-indexer-light-sdk to verify the balances.We include a demo in this PR, and here are some screen recordings for showcasing.
By clicking the
Verify
button, we fetch the verified checkpoints from official Nubit Modular Indexer (Committee) instances and do a double verification on the balance proofs. Once it's successful, we display the proofs on the tooltip.wallet-extension-verified.1.mp4
Upon malicious checkpoints, the tooltip would list all the commitments of the checkpoints and the SDK would try doing a reconstruction using the last consistent checkpoint.
wallet-extension-unverified.1.mp4
We sincerely look forward to your thoughts and ideas!