Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chores： Refactor and Improve Codebase Readability and Documentation #215

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

chores： Refactor and Improve Codebase Readability and Documentation #215

wants to merge 7 commits into from

Conversation

dima-safin-2025
Copy link

This PR introduces multiple enhancements aimed at improving the readability, style, and documentation of our codebase. Below is a detailed list of changes included in this PR:

Style Improvements:

  • Remove unnecessary 'px' from zero values

Documentation Updates:

  • Update function documentation for clarity and completeness

Code Refactorings:

  • Simplify boolean expressions for clarity

  • Use path alias for utils import in formatDate

  • Simplify control flow and remove redundant break

  • Simplify boolean expressions and remove verbose constructs

@dima-safin-2025
style: remove unnecessary 'px' from zero values
c66956a
@dima-safin-2025
docs: update function documentation for clarity and completeness
3c36b48 
- Added missing parameter description for `addressType` in `importPrivateKey` function.
- Corrected inconsistencies in the `importPrivateKey` function docs, including parameter annotations and return type details.
- Ensured all parameters and emitted events are properly documented.
@dima-safin-2025
refactor: simplify boolean expressions for clarity
445a8c9 
- Use logical negation directly to simplify conditions in redirect check.
- Simplify conditional checks in `parseSignPsbtUr` by using double negation (!!).
@dima-safin-2025
refactor: use path alias for utils import in formatDate
410b540 
- Change import path from relative to alias for better maintainability and readability.
@dima-safin-2025
refactor: simplify control flow and remove redundant break
29df649
@dima-safin-2025
refactor: simplify boolean expressions and remove verbose constructs
22000c9
@dima-safin-2025
Merge remote-tracking branch 'upstream/master'
81ae4cd 
# Conflicts:
#	src/ui/pages/MainRoute.tsx
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TeriThetha TeriThetha TeriThetha approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dima-safin-2025 @TeriThetha