forked from Uniswap/deploy-v3
-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
zkSync era #1
Open
AntonD3
wants to merge
20
commits into
main
Choose a base branch
from
zksync-era
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
zkSync era #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vladbochok
reviewed
Apr 20, 2023
vladbochok
approved these changes
May 2, 2023
* License formatting * Fix code style issues with Prettier * yarn start in readme
vladbochok
reviewed
Aug 30, 2023
Co-authored-by: Vlad Bochok <41153528+vladbochok@users.noreply.github.com>
vladbochok
reviewed
Aug 30, 2023
Usage: yarn start [--confirmations <STRING>] [--gas-price <STRING>] --json-rpc <STRING> --native-currency-label <STRING> --owner-address <STRING> --private-key <STRING> [--state <STRING>] [--v2-core-factory-address <STRING>] --weth9-address <STRING> | ||
|
||
OPTIONS: | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Redundant line?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's actually just the output of yarn start --help
, but we can remove this line for consistency
vladbochok
approved these changes
Aug 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.