-
Notifications
You must be signed in to change notification settings - Fork 881
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/improve integer indexes #1191
Conversation
Codecov ReportBase: 93.71% // Head: 93.77% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #1191 +/- ##
==========================================
+ Coverage 93.71% 93.77% +0.05%
==========================================
Files 83 83
Lines 8416 8414 -2
==========================================
+ Hits 7887 7890 +3
+ Misses 529 524 -5
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice and thanks a lot! These are very important changes.
I tested most of the changes and added some minor comments.
What do you think in general of adding some examples (not in this PR) for the most of "get" methods for documentation? Could be helpful for the user as some of these methods have quite different behavior depending on input and underlying series.
@@ -3974,6 +4011,15 @@ def __getitem__( | |||
|
|||
.. warning:: | |||
slices use pandas convention of including both ends of the slice. | |||
|
|||
Notes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As getitem gets more complex, I believe now would be a good point either to add examples for all cases (probably better) or a userguide. Would probably make more sense in another PR.
What do you think?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Absolutely agree! #1227
Co-authored-by: Dennis Bader <dennis.bader@gmx.ch>
Co-authored-by: Dennis Bader <dennis.bader@gmx.ch>
Co-authored-by: Dennis Bader <dennis.bader@gmx.ch>
Co-authored-by: Dennis Bader <dennis.bader@gmx.ch>
Co-authored-by: Dennis Bader <dennis.bader@gmx.ch>
…ts into feat/improve-integer-indexes
Co-authored-by: Dennis Bader <dennis.bader@gmx.ch>
Solves #974 and fixes a series of small issues we had with integer-indexed series:
TimeSeries.get_index_at_point()
was not behaving as expected on integer-indexed series with index not starting at 0RangeIndex
was having astep > 1
.TimeSeries.gaps()
method had an issue with integer-indexed series.[]
indexing, which would have failed for series not starting at 0 or with step > 1. Fixes Feat/improve integer indexes #1191This PR supersedes #1180, which I'll now close.