Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/multi forecast fut cov #1481

Merged
merged 3 commits into from
Jan 12, 2023
Merged

Fix/multi forecast fut cov #1481

merged 3 commits into from
Jan 12, 2023

Conversation

dumjax
Copy link
Contributor

@dumjax dumjax commented Jan 11, 2023

Fixes when only fut cov.

@codecov-commenter
Copy link

Codecov Report

Base: 93.93% // Head: 93.91% // Decreases project coverage by -0.02% ⚠️

Coverage data is based on head (5c9514b) compared to base (f0035e3).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1481      +/-   ##
==========================================
- Coverage   93.93%   93.91%   -0.03%     
==========================================
  Files         122      122              
  Lines       10742    10728      -14     
==========================================
- Hits        10091    10075      -16     
- Misses        651      653       +2     
Impacted Files Coverage Δ
darts/models/forecasting/forecasting_model.py 97.05% <100.00%> (ø)
darts/timeseries.py 91.78% <0.00%> (-0.23%) ⬇️
darts/ad/anomaly_model/filtering_am.py 91.93% <0.00%> (-0.13%) ⬇️
...arts/models/forecasting/torch_forecasting_model.py 89.52% <0.00%> (-0.05%) ⬇️
darts/models/forecasting/block_rnn_model.py 98.24% <0.00%> (-0.04%) ⬇️
darts/models/forecasting/nhits.py 99.27% <0.00%> (-0.01%) ⬇️
darts/datasets/__init__.py 100.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@hrzn
Copy link
Contributor

hrzn commented Jan 12, 2023

Fixes #1466

@hrzn hrzn linked an issue Jan 12, 2023 that may be closed by this pull request
Copy link
Contributor

@hrzn hrzn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@hrzn hrzn merged commit ce45c15 into master Jan 12, 2023
@madtoinou madtoinou deleted the fix/multi-forecast-fut-cov branch July 5, 2023 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix historical_forecasts() with future covariates
3 participants