Fix/dlinear padding for even kernel size #1695
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tation of the padding in the constructor instead of the forward method
madtoinou
force-pushed
the
fix/dlinear_padding
branch
from
e374b2d
to
1f55719
Compare
Codecov ReportPatch coverage:
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more Additional details and impacted files@@ Coverage Diff @@
## master #1695 +/- ##
==========================================
- Coverage 94.15% 94.04% -0.11%
==========================================
Files 125 125
Lines 11466 11456 -10
==========================================
- Hits 10796 10774 -22
- Misses 670 682 +12
... and 10 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
dennisbader
approved these changes
Apr 11, 2023
There was a problem hiding this comment.
Looks good, thanks @madtoinou 🚀 Is there any source to explain why this works/is better?
alexcolpitts96
pushed a commit
to alexcolpitts96/darts
that referenced
this pull request
May 31, 2023
* fix: asymetrical padding when using even kernel size, moved the computation of the padding in the constructor instead of the forward method * feat: added unitest to cover both even and odd kernel size values --------- Co-authored-by: Dennis Bader <dennis.bader@gmx.ch>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1613.
Summary
Dlinear was supporting odd kernel size only. Instead of enforcing this restriction, use asymmetrical padding for even kernel size (one less sample on the front/start/left side of the input
TimeSeries). Also updated the docstring for this argument.Other Information
Added corresponding tests.