Fix/representation of model with DataFrame/Array parameters #1749
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… representation for pd.DataFrame and np.ndarray to avoid ambiguity when checking equality
Codecov ReportPatch coverage has no change and project coverage change:
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. Additional details and impacted files@@ Coverage Diff @@
## master #1749 +/- ##
==========================================
- Coverage 94.19% 94.06% -0.13%
==========================================
Files 125 125
Lines 11505 11491 -14
==========================================
- Hits 10837 10809 -28
- Misses 668 682 +14
☔ View full report in Codecov by Sentry. |
dennisbader
reviewed
May 19, 2023
Comment on lines
1896
to
1901
| if include_default_params | ||
| or ( | ||
| isinstance(v, (pd.DataFrame, np.ndarray)) | ||
| and np.any(v != default_model_params.get(k, None)) | ||
| ) | ||
| or v != default_model_params.get(k, None) |
There was a problem hiding this comment.
I think we can use np in general
Suggested change
| if include_default_params | |
| or ( | |
| isinstance(v, (pd.DataFrame, np.ndarray)) | |
| and np.any(v != default_model_params.get(k, None)) | |
| ) | |
| or v != default_model_params.get(k, None) | |
| if include_default_params | |
| or np.any(v != default_model_params.get(k, None)) |
alexcolpitts96
pushed a commit
to alexcolpitts96/darts
that referenced
this pull request
May 31, 2023
…1749) * fix: added a test case when comparing the parameters for model string representation for pd.DataFrame and np.ndarray to avoid ambiguity when checking equality * fix: using the proper operator to detect inequality * fix: applying reviwer suggestion to simplify test --------- Co-authored-by: Dennis Bader <dennis.bader@gmx.ch>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1746.
Summary
Use
np.anywhen trying to comparepd.DataFrame(holidaysofProphetfor example) andnp.ndarrayparameters with the defaults when generating the representation string of a model in_get_model_description_string().Other Information
Not sure that showing the whole dataframe is the best approach, we could eventually use the
.head? Or have a placeholder name such as "CustomDataFrame"?