Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix getitem with rangeindex start != 0 and freq != 1 #1868

Merged
merged 3 commits into from
Jun 29, 2023

Conversation

dennisbader
Copy link
Collaborator

Summary

  • fixes TimeSeries __getitem__ with series that have a RangeIndex with start != 0 and freq != 1.
  • adds unit test for getitem of integer indexed series

@codecov-commenter
Copy link

Codecov Report

Patch coverage: 83.33% and project coverage change: -0.14 ⚠️

Comparison is base (b668a4e) 94.29% compared to head (ed84770) 94.16%.

❗ Current head ed84770 differs from pull request most recent head 49c2d4f. Consider uploading reports for the commit 49c2d4f to get more accurate results

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1868      +/-   ##
==========================================
- Coverage   94.29%   94.16%   -0.14%     
==========================================
  Files         125      125              
  Lines       11636    11627       -9     
==========================================
- Hits        10972    10948      -24     
- Misses        664      679      +15     
Impacted Files Coverage Δ
darts/timeseries.py 92.46% <ø> (-0.22%) ⬇️
...sing/transformers/static_covariates_transformer.py 97.36% <83.33%> (-1.96%) ⬇️

... and 9 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Collaborator

@madtoinou madtoinou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, congratulation for spotting this bug 🚀

@dennisbader dennisbader merged commit 344d40a into master Jun 29, 2023
@dennisbader dennisbader deleted the fix/ts_getitem_with_rangeindex branch June 29, 2023 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants