-
Notifications
You must be signed in to change notification settings - Fork 881
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor/unittests #1950
Refactor/unittests #1950
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! The tests look much nicer, the improve granularity will for sure help us pinpoint the problematic use-case.
Few comments to make some assert more intuitive.
Codecov ReportPatch and project coverage have no change.
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. Additional details and impacted files@@ Coverage Diff @@
## master #1950 +/- ##
=======================================
Coverage 93.83% 93.84%
=======================================
Files 132 132
Lines 12731 12717 -14
=======================================
- Hits 11946 11934 -12
+ Misses 785 783 -2 ☔ View full report in Codecov by Sentry. |
Summary