Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor/unittests #1950

Merged
merged 17 commits into from
Aug 17, 2023
Merged

Refactor/unittests #1950

merged 17 commits into from
Aug 17, 2023

Conversation

dennisbader
Copy link
Collaborator

@dennisbader dennisbader commented Aug 10, 2023

Summary

  • refactor unit tests to use pytest instead of unit test
  • add common pytest fixtures (decorators) to conftest.py
  • parametrize the heavy tests tests

Copy link
Collaborator

@madtoinou madtoinou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! The tests look much nicer, the improve granularity will for sure help us pinpoint the problematic use-case.

Few comments to make some assert more intuitive.

darts/tests/ad/test_anomaly_model.py Outdated Show resolved Hide resolved
darts/tests/ad/test_anomaly_model.py Outdated Show resolved Hide resolved
darts/tests/ad/test_anomaly_model.py Outdated Show resolved Hide resolved
darts/tests/ad/test_detectors.py Outdated Show resolved Hide resolved
darts/tests/ad/test_detectors.py Outdated Show resolved Hide resolved
darts/tests/models/forecasting/test_tide_model.py Outdated Show resolved Hide resolved
darts/tests/models/forecasting/test_transformer_model.py Outdated Show resolved Hide resolved
darts/tests/models/forecasting/test_transformer_model.py Outdated Show resolved Hide resolved
darts/tests/utils/test_model_selection.py Outdated Show resolved Hide resolved
darts/tests/conftest.py Show resolved Hide resolved
@codecov-commenter
Copy link

Codecov Report

Patch and project coverage have no change.

Comparison is base (b1290cb) 93.83% compared to head (c668f94) 93.84%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1950   +/-   ##
=======================================
  Coverage   93.83%   93.84%           
=======================================
  Files         132      132           
  Lines       12731    12717   -14     
=======================================
- Hits        11946    11934   -12     
+ Misses        785      783    -2     

see 8 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dennisbader dennisbader merged commit 7c6e04a into master Aug 17, 2023
9 checks passed
@dennisbader dennisbader deleted the refactor/unittests branch August 17, 2023 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Released
Development

Successfully merging this pull request may close these issues.

3 participants