Fix: broken dataset links in transfer learning notebook #2067
Conversation
…lts sligthly changed
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #2067 +/- ##
==========================================
- Coverage 93.82% 93.81% -0.01%
==========================================
Files 134 134
Lines 13091 13077 -14
==========================================
- Hits 12282 12268 -14
Misses 809 809 ☔ View full report in Codecov by Sentry. |
|
View / edit / reply to this conversation on ReviewNB dennisbader commented on 2023-11-15T09:30:48Z The compute durations written for the different models have been obtained by running the notebook on a i9-10900K CPU, with an RTX 2080s GPU, with Python 3.9.7 and Darts 0.18.0.
Can you update this with the setup you used? madtoinou commented on 2023-11-15T22:37:27Z I updated the config, I could try to run the notebook on a more powerful config if you think that it would be more meaningful for users. dennisbader commented on 2023-11-16T07:26:20Z All good like this, thanks |
|
View / edit / reply to this conversation on ReviewNB dennisbader commented on 2023-11-15T09:30:49Z you might want to cut out the cell output here to hide your machine paths :) |
|
View / edit / reply to this conversation on ReviewNB dennisbader commented on 2023-11-15T09:30:50Z sMAPE of about 27.2. |
|
View / edit / reply to this conversation on ReviewNB dennisbader commented on 2023-11-15T09:30:51Z The median is better for with the naive seasonal
->
Slightly better than the naive seasonal model. |
|
View / edit / reply to this conversation on ReviewNB dennisbader commented on 2023-11-15T09:30:51Z with good forecasting accuracy and about 10x faster
->
with good forecasting accuracy and lower computational cost.
--- Not related to this PR but it's a bit worrying how ARIMA takes much longer than in the original version madtoinou commented on 2023-11-15T22:38:52Z I don't know if it's caused by the hardware or a change in the implementation since darts 0.18.0. Another difference is that the series are slightly longer on average with this version of the passengers per carrier. |
|
View / edit / reply to this conversation on ReviewNB dennisbader commented on 2023-11-15T09:30:52Z Line #20. # change this one to "gpu" if your notebook does run in a GPU environment: you can use “auto” so it automatically uses gpu if available madtoinou commented on 2023-11-15T22:41:02Z I forced "cpu" because with the Apple Silicon macbook, the gpu (mps) acceleration does not support dennisbader commented on 2023-11-16T07:28:31Z Ah okay, than it's alright |
|
View / edit / reply to this conversation on ReviewNB dennisbader commented on 2023-11-15T09:30:53Z tradeoff between accuracy and speed (about 85x faster than ARIMA for similar accuracy).
->
tradeoff between accuracy and speed. |
|
View / edit / reply to this conversation on ReviewNB dennisbader commented on 2023-11-15T09:30:54Z Line #18. # change this one to "gpu" if your notebook does run in a GPU environment: same here with "auto" |
|
View / edit / reply to this conversation on ReviewNB dennisbader commented on 2023-11-15T09:30:55Z The forecasting step with N-BEATS is ~350x faster than the fit-predict step we needed with ARIMA, and about 4x faster than the fit-predict step of linear regression.
->
The forecasting step with N-BEATS is more than 1000x faster than the fit-predict step we needed with ARIMA, and also faster than with linear regression. |
|
View / edit / reply to this conversation on ReviewNB dennisbader commented on 2023-11-15T09:30:56Z The part about regression being slower can be removed now, as this was optimized |
|
View / edit / reply to this conversation on ReviewNB dennisbader commented on 2023-11-15T09:30:57Z ARIMA performs best but is about 170x slower than N-BEATS...
now it's around 1k times slower
----
Note that two models out of the 3 most accurate (Exponential Smoothing and Kalman Filter) did not perform so well when used on the air passengers series
--->
Note also that Exponential Smoothing and Kalman Filter now perform much better than when we used them on the air passengers series.
|
There was a problem hiding this comment.
Looks great, thanks a lot @madtoinou 🚀
Had some suggestions here and there mainly about updating the plot explanations with the new numbers
|
I updated the config, I could try to run the notebook on a more powerful config if you think that it would be more meaningful for users. View entire conversation on ReviewNB |
|
I don't know if it's caused by the hardware or a change in the implementation since darts 0.18.0. Another difference is that the series are slightly longer on average with this version of the passengers per carrier. View entire conversation on ReviewNB |
|
I forced "cpu" because with the Apple Silicon macbook, the gpu (mps) acceleration does not support View entire conversation on ReviewNB |
|
All good like this, thanks View entire conversation on ReviewNB |
|
Ah okay, than it's alright View entire conversation on ReviewNB |
Fixes #1948.
Summary
Other informations