Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump version of pytorch-lightning to 2.0.0 #2087

Merged
merged 5 commits into from
Dec 1, 2023

Conversation

eschibli
Copy link
Contributor

Fixes #2086

Summary

Changed torch requirements to require pytorch-lightning>=2.0 due to dependency on ProgressBar

Copy link
Collaborator

@dennisbader dennisbader left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @eschibli and thanks for this fix.

It might be a bit early for us to discard lightning<2.0.0.

What I would suggest is to adapt the ProgressBar import in darts.models.forecasting.torch_forecasting_model.py.

Move the progressbar import in this line into the version specific imports from here:

if pl_200_or_above:
    from pytorch_lightning.tuner import Tuner
    from pytorch_lightning.callbacks import ProgressBar
else:
    from pytorch_lightning.tuner.tuning import Tuner
    from pytorch_lightning.callbacks import ProgressBarBase

@dennisbader
Copy link
Collaborator

Hi @eschibli. I applied the changes already, as we want to release a patch for this soon.
Thanks again for your contribution 🚀

Copy link
Collaborator

@dennisbader dennisbader left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @eschibli 🚀 💯

@dennisbader dennisbader merged commit b20a1f2 into unit8co:master Dec 1, 2023
7 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] torch_forecasting_model depends on pytorch-lightining>=2.0
2 participants