Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

numpy 2.0 replacing deprecated namespace #2553

Merged
merged 3 commits into from
Nov 14, 2024

Conversation

quant12345
Copy link
Contributor

Checklist before merging this PR:

  • Mentioned all issues that this PR fixes or addresses.
  • Summarized the updates of this PR under Summary.
  • Added an entry under Unreleased in the Changelog.

Fixes #.

numpy 2.0 replacing deprecated namespace

Summary

Other Information

Copy link

codecov bot commented Oct 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.09%. Comparing base (d60ef87) to head (ec07169).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2553      +/-   ##
==========================================
- Coverage   94.14%   94.09%   -0.06%     
==========================================
  Files         139      139              
  Lines       14884    14884              
==========================================
- Hits        14013    14005       -8     
- Misses        871      879       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@madtoinou madtoinou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, the changes are consistent with the modification applied by the ruff module recommended in the official migration instructions.

We just need to make sure that it does not break the back-compatibility with python 3.9

@dennisbader dennisbader merged commit bb24999 into unit8co:master Nov 14, 2024
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants