Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix bug in create lagged component names without target lags #2576

Merged
merged 3 commits into from
Nov 2, 2024

Conversation

dennisbader
Copy link
Collaborator

Checklist before merging this PR:

  • Mentioned all issues that this PR fixes or addresses.
  • Summarized the updates of this PR under Summary.
  • Added an entry under Unreleased in the Changelog.

Fixes #2574.

Summary

  • Fixes a bug when using darts.utils.data.tabularization.create_lagged_component_names() with target lags=None, that did not return any lagged target label component names.

Copy link

codecov bot commented Nov 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.87%. Comparing base (0b9efd0) to head (2f1d043).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2576      +/-   ##
==========================================
- Coverage   93.88%   93.87%   -0.02%     
==========================================
  Files         139      139              
  Lines       14862    14850      -12     
==========================================
- Hits        13953    13940      -13     
- Misses        909      910       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dennisbader dennisbader merged commit c116405 into master Nov 2, 2024
7 of 9 checks passed
@dennisbader dennisbader deleted the fix/target_lags_comp_names_no_target_labs branch November 2, 2024 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] create_lagged_component_names does not return target column names
1 participant