Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: refactoring codebase #4

Merged
merged 5 commits into from
May 2, 2022
Merged

chore: refactoring codebase #4

merged 5 commits into from
May 2, 2022

Conversation

ahoy-jon
Copy link
Member

@ahoy-jon ahoy-jon commented May 2, 2022

No description provided.

@dylandoamaral dylandoamaral changed the title refactoring-review chore: refactoring May 2, 2022
final case class Page(page: Id) extends MentionData
final case class Database(database: Id) extends MentionData

/* final case class TemplateMention(templateMention: TemplateMention.TemplateMentionData)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pourquoi c'est commenté ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dylandoamaral ce n'était pas clair ce que cela faisait là, il était orphelin (il n'y avait pas le extends MentionData)

@dylandoamaral dylandoamaral changed the title chore: refactoring chore: refactoring codebase May 2, 2022
@dylandoamaral dylandoamaral merged commit f98df37 into master May 2, 2022
@dylandoamaral dylandoamaral deleted the refactoring-review branch May 2, 2022 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants