Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add void to fix deprecation #2

Merged
merged 2 commits into from
Mar 12, 2024
Merged

add void to fix deprecation #2

merged 2 commits into from
Mar 12, 2024

Conversation

mattbild
Copy link
Contributor

@mattbild mattbild commented Feb 23, 2024

return void is needed in ExtensionInterface's implementation:

See deprecation message:
Method "Symfony\Component\DependencyInjection\Extension\ExtensionInterface::load()" might add "void" as a native return type declaration in the future.
Do the same in implementation "UnivLorraine\Bundle\SymfonyCasBundle\DependencyInjection\UnivLorraineSymfonyCasExtension" now to avoid errors or add an explicit @return annotation to suppress this message.

And replace Symfony\Component\Security\Core\Security:

Since symfony/security-bundle 6.2: The "Symfony\Component\Security\Core\Security" service alias is deprecated, use "Symfony\Bundle\SecurityBundle\Security" instead. It is being referenced by the "univ_lorraine_symfony_cas.authenticator" service.

@mattbild mattbild requested a review from benjhoo February 23, 2024 13:33
@benjhoo benjhoo merged commit 2e211fb into main Mar 12, 2024
1 check passed
@mattbild mattbild deleted the deprecated branch March 13, 2024 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants