Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: badges generator #12

Merged
merged 16 commits into from
Feb 7, 2024
Merged

feat: badges generator #12

merged 16 commits into from
Feb 7, 2024

Conversation

cpreston321
Copy link
Member

@cpreston321 cpreston321 commented Feb 7, 2024

πŸ”— Linked issue

#3

❓ Type of change

  • πŸ“– Documentation (updates to the documentation, readme, or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

Resolves: #3

  • Added support for AUTOMD args with - e.g. version-name="hello" Test Here
  • Added custom support for overwrites if needed.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@cpreston321 cpreston321 changed the title feat: badges generator feat: badges generator Feb 7, 2024
src/generators/badges.ts Outdated Show resolved Hide resolved
src/generators/badges.ts Outdated Show resolved Hide resolved
@cpreston321 cpreston321 marked this pull request as ready for review February 7, 2024 12:44
@cpreston321
Copy link
Member Author

@pi0 the new _parse doesn't support - args does it?

@pi0
Copy link
Member

pi0 commented Feb 7, 2024

@cpreston321 seems working on playground.. (added test too: c04df9d)

@cpreston321
Copy link
Member Author

cpreston321 commented Feb 7, 2024

Update: You beat me to it haha


@pi0 I just tested it too πŸ‘πŸΌ Works like a charm should prob add to test case.

const tests = [
    [`foo`, { foo: true }],
    [`no-foo`, { foo: false }],
    [`foo="bar"`, { foo: "bar" }],
    [`foo=bar`, { foo: "bar" }],
    ['foo-bar="baz"', { "foo-bar": "baz" }],
  ] as const;

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@pi0
Copy link
Member

pi0 commented Feb 7, 2024

(working on some local refactors. please don't push more commits likely they will be overridden)

@cpreston321
Copy link
Member Author

@pi0 Just saw this :( Sorry. I accidentally pushed read me updates.

README.md Outdated Show resolved Hide resolved
@pi0
Copy link
Member

pi0 commented Feb 7, 2024

No worries @cpreston321. I have pushed some changes in 94fca68

In summary:

  • We now also infer github from pkg too to use it in URLs that need it
  • Updated implementation to support badgen (which is faster) and shields
  • Defenitions are now more strict as result. We check for no-npmDownloads and no-npmVersion (I had some reasons for this convention in future) strictly

I hope you are happy with them and ideas welcome!

README.md Outdated Show resolved Hide resolved
Co-authored-by: uncenter <47499684+uncenter@users.noreply.github.com>
@pi0 pi0 merged commit 8db8058 into main Feb 7, 2024
2 checks passed
@pi0 pi0 deleted the feat/badges branch February 7, 2024 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Badge Generator
3 participants