Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add global arg to pm-install generator #53

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

HugoRCD
Copy link

@HugoRCD HugoRCD commented Mar 25, 2024

πŸ”— Linked issue

(#50)

❓ Type of change

  • πŸ“– Documentation (updates to the documentation, readme, or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

Add a generator like pm-install but for global package like CLI

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@HugoRCD HugoRCD marked this pull request as ready for review March 26, 2024 09:30
@HugoRCD
Copy link
Author

HugoRCD commented Mar 26, 2024

The generator works, I just don't know why it's not recognized in the docs when everywhere else (tests, code, etc...) it works.
Don't hesitate to send me any feedback!

@pi0
Copy link
Member

pi0 commented Mar 26, 2024

Thanks for PR. But i guess you can make it an arg for pm-install global

@pi0 pi0 marked this pull request as draft March 26, 2024 10:10
@HugoRCD
Copy link
Author

HugoRCD commented Mar 26, 2024

Yes indeed, I thought about it, but I thought that for a global installation, all the arguments available with pm-install are not necessarily interesting.

@HugoRCD HugoRCD marked this pull request as ready for review March 26, 2024 11:07
@HugoRCD HugoRCD changed the title feat: add pm-g generator feat: add global arg to pm-install generator Mar 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants