Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: fix subpath types #265

Merged
merged 1 commit into from
Dec 1, 2023

Conversation

shinGangan
Copy link
Contributor

πŸ”— Linked issue

resolved #239 .

❓ Type of change

  • πŸ“– Documentation (updates to the documentation, readme, or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

🏒 Environment

  • Mac OS
  • VS Code
  • Node.js: 20.5.0
  • consol: 3.2.3
$ npm ls | grep consola
β”œβ”€β”€ consola@3.2.3

πŸ“š Description

I installed and used consola and got TS2307 error with the following two.

  • consola/basic
  • consola/browser

The following worked correctly.

  • consola/core
  • console/utils

Checked installed modules, basic.d.ts and browser.d.ts were not included.

$ ls node_modules/consola    
LICENSE         core.d.ts       lib             utils.d.ts
README.md       dist            package.json

Checked the exports field in package.json and found that the file names were different. This PR was fixed this.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@shinGangan
Copy link
Contributor Author

Hi @pi0 .

I would appreciate it if you could approve the workflows and review when you have time.

@pi0 pi0 changed the title fix(types): Type declarations for consola/basic and consola/browser not found build: fix subpath types Dec 1, 2023
Copy link

codecov bot commented Dec 1, 2023

Codecov Report

All modified and coverable lines are covered by tests βœ…

Comparison is base (90d4807) 61.13% compared to head (26c37d1) 61.13%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #265   +/-   ##
=======================================
  Coverage   61.13%   61.13%           
=======================================
  Files          13       13           
  Lines        1379     1379           
  Branches       58       58           
=======================================
  Hits          843      843           
  Misses        536      536           

β˜” View full report in Codecov by Sentry.
πŸ“’ Have feedback on the report? Share it here.

@pi0 pi0 merged commit ad01ec4 into unjs:main Dec 1, 2023
4 checks passed
@shinGangan
Copy link
Contributor Author

@pi0, thanks for the merge.

Glad to contribute to unjs. I hope to continue to contribute where I can.

@shinGangan shinGangan deleted the fix/239-type-declarations-not-found branch December 1, 2023 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Modules for consola/browser and consola/basic not found in typescript project
2 participants