Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: mysql connector #86

Merged
merged 8 commits into from
Oct 9, 2024
Merged

feat: mysql connector #86

merged 8 commits into from
Oct 9, 2024

Conversation

arashsheyda
Copy link
Contributor

πŸ”— Linked issue

related to #32

❓ Type of change

  • πŸ“– Documentation (updates to the documentation, readme, or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

this PR adds support for mysql connector using mysql2 + an example of mysql (also I'm sorry in advanced if I over stepped, I was checking this fantastic module and couldn't resist trying)

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@arashsheyda arashsheyda changed the title feat(connector): mysql2 feat(connectors): mysql2 support Apr 19, 2024
@pi0 pi0 changed the title feat(connectors): mysql2 support feat: mysql connector Oct 9, 2024
Copy link
Member

@pi0 pi0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks ❀️

@pi0 pi0 merged commit 6d9152f into unjs:main Oct 9, 2024
2 checks passed
Copy link

codecov bot commented Oct 9, 2024

Codecov Report

Attention: Patch coverage is 26.19048% with 31 lines in your changes missing coverage. Please review.

Please upload report for BASE (main@7e7a4ef). Learn more about missing BASE report.

Files with missing lines Patch % Lines
src/connectors/mysql2.ts 26.19% 31 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main      #86   +/-   ##
=======================================
  Coverage        ?   41.55%           
=======================================
  Files           ?       17           
  Lines           ?      616           
  Branches        ?       52           
=======================================
  Hits            ?      256           
  Misses          ?      355           
  Partials        ?        5           

β˜” View full report in Codecov by Sentry.
πŸ“’ Have feedback on the report? Share it here.

@arashsheyda arashsheyda deleted the feat/mysql2-connector branch October 9, 2024 22:08
@sys-tps
Copy link

sys-tps commented Nov 11, 2024

Thank you very much !
I wait for this a very long time...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants