fix: merge objects with Module type
#121
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #121 +/- ##
==========================================
+ Coverage 44.74% 45.73% +0.99%
==========================================
Files 4 4
Lines 219 223 +4
Branches 33 35 +2
==========================================
+ Hits 98 102 +4
Misses 119 119
Partials 2 2 ☔ View full report in Codecov by Sentry. |
src/defu.ts
Outdated
| @@ -57,8 +56,7 @@ function _isPlainObject(value: unknown): boolean { | |||
| (prototype === null || | |||
| prototype === Object.prototype || | |||
| Object.getPrototypeOf(prototype) === null) && | |||
| !(Symbol.toStringTag in value) && | |||
| !(Symbol.iterator in value) | |||
| (!(Symbol.toStringTag in value) || !(Symbol.iterator in value)) | |||
There was a problem hiding this comment.
I'm wondering if it is purely for Date merging fix, using instance of Date would be faster
There was a problem hiding this comment.
it isn't. See the linked issue. It also applies to Module (import via *)
There was a problem hiding this comment.
Oh, I see! With this PR want to merge Module instances!
There was a problem hiding this comment.
Checking, this logic currently basically bypasses entire L59 as iterator symbol does not exist in any of tested values (removing the line also all the tests pass). Wondering how we can cover it
There was a problem hiding this comment.
Oh, I see! With this PR want to merge Module instances!
yes indeed 👍🏻
There was a problem hiding this comment.
Checking, this logic currently basically bypasses entire L59 as iterator symbol does not exist in any of tested values (removing the line also all the tests pass). Wondering how we can cover it
Oh, I see 🤔 That's a bit tricky. I also wonder how to cover it then...
But - do we need to? Dates are correctly replaced (not merged) like that too
There was a problem hiding this comment.
I have ported test suite of is-plain-object (see commits to main) and also merged in with this PR. Intrestingly we will be breaking two more tests at least (Math and native arguments will be wrongly detected as pure object)
There was a problem hiding this comment.
Updated with a logic that precisely works for Module to reduce (more!) regression chances
pi0
changed the title
🔗 Linked issue
Resolves #119
❓ Type of change
📚 Description
📝 Checklist