Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: detect invalid node imports #4

Merged
merged 8 commits into from
Oct 28, 2021
Merged

Conversation

danielroe
Copy link
Member

@danielroe danielroe commented Oct 28, 2021

pending unjs/mlly#20

@danielroe danielroe added the enhancement New feature or request label Oct 28, 2021
@danielroe danielroe requested a review from pi0 October 28, 2021 10:02
@danielroe danielroe self-assigned this Oct 28, 2021
src/externals.ts Outdated Show resolved Hide resolved
src/externals.ts Show resolved Hide resolved
Co-authored-by: pooya parsa <pyapar@gmail.com>
@pi0
Copy link
Member

pi0 commented Oct 28, 2021

@danielroe mlly updated with built-in check fix. Feel free to merge and release when ready.

@danielroe
Copy link
Member Author

rebased my local changes - apologies if anything moved around accidentally

@danielroe danielroe marked this pull request as ready for review October 28, 2021 16:50
@danielroe danielroe merged commit 114f1d6 into main Oct 28, 2021
@danielroe danielroe deleted the feat/detect-invalid-esm branch October 28, 2021 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants