Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: improve internal babel types #271

Merged
merged 8 commits into from
Jul 26, 2024
Merged

refactor: improve internal babel types #271

merged 8 commits into from
Jul 26, 2024

Conversation

aryaemami59
Copy link
Contributor

This PR:

  • Provides missing type definitions for some of the babel related packages through module augmentations and ambient declaration files.
  • Corrects some of the extisiting types.
  • Fixes a very minor issue related to snapshots on Windows.

pi0
pi0 reviewed Jul 4, 2024
View reviewed changes
src/plugins/transform-module/dynamic-import.ts Outdated Show resolved Hide resolved
src/plugins/transform-module/index.ts Outdated Show resolved Hide resolved
@pi0 pi0 changed the title build: fix type issues related to babel refactor: improve internal babel types Jul 26, 2024
@pi0 pi0 merged commit fb53cbc into unjs:main Jul 26, 2024
5 checks passed
@aryaemami59 aryaemami59 deleted the fix-babel-type-issues branch July 30, 2024 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pi0 pi0 pi0 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aryaemami59 @pi0