Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: try to resolve .ts files with .js extension from js files #337

Merged
merged 1 commit into from
Nov 1, 2024
Merged

fix: try to resolve .ts files with .js extension from js files #337

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/resolve.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,8 @@ export function jitiResolve(
// Try resolving .ts files with .js extension
if (
TS_EXT_RE.test(ctx.filename) ||
TS_EXT_RE.test(ctx.parentModule?.filename || "")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While tests might pass (and I immediately cannot recall why we needed this check) it might be a safer option to add new checks in addition to the current ones.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah just to make you aware of the situation. Pushed a minimal change/fix now.

TS_EXT_RE.test(ctx.parentModule?.filename || "") ||
JS_EXT_RE.test(id)
) {
resolved = tryNativeRequireResolve(
ctx,
Expand Down