fix(isValidNodeImport): detect invalid cjs modules (#187)

src/syntax.ts

@@ -94,5 +94,5 @@ export async function isValidNodeImport(
     (await fsp.readFile(resolvedPath, "utf8").catch(() => {})) ||
     "";
 
-  return hasCJSSyntax(code) || !hasESMSyntax(code);
+  return !hasESMSyntax(code);
 }

test/fixture/imports/js-cjs/index.js

@@ -1,2 +1,4 @@
 // eslint-disable-next-line unicorn/prefer-module
 module.exports = "js-cjs";
+
+console.log(import("node:fs"));

test/fixture/imports/mixed/index.js

@@ -0,0 +1,12 @@
+/* eslint-disable unicorn/prefer-module */
+export const isCrtAvailable = () => {
+  try {
+    if (
+      typeof require === "function" &&
+      typeof module !== "undefined" &&
+      require("aws-crt")
+    ) {
+      return ["md/crt-avail"];
+    }
+  } catch {}
+};

test/fixture/imports/mixed/package.json

@@ -0,0 +1,5 @@
+{
+  "name": "mixed",
+  "version": "1.0.0",
+  "main": "index.cjs"
+}

test/syntax.test.ts

@@ -110,6 +110,7 @@ const nodeImportTests = {
   [join(import.meta.url, "../fixture/imports/js-esm")]: false,
   [join(import.meta.url, "../fixture/imports/js-esm/es/index.mjs")]: true,
   [join(import.meta.url, "../fixture/imports/js-esm/es/index.js")]: false,
+  [join(import.meta.url, "../fixture/imports/mixed")]: false,
 };
 
 describe("isValidNodeImport", () => {