Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support protocols for isValidNodeImport #20

Merged
merged 8 commits into from
Oct 28, 2021
Merged

feat: support protocols for isValidNodeImport #20

merged 8 commits into from
Oct 28, 2021

Conversation

danielroe
Copy link
Member

  • add and expose isBuiltin utility
  • add internal getProtocol utility

@danielroe
feat: support protocols for isValidNodeImport
4f58207 
* add and expose `isBuiltin` utility
* add internal `getProtocol` utility
@danielroe danielroe added the enhancement New feature or request label Oct 28, 2021
@danielroe danielroe requested a review from pi0 October 28, 2021 11:28
@danielroe danielroe self-assigned this Oct 28, 2021
pi0
pi0 reviewed Oct 28, 2021
View reviewed changes
src/syntax.ts Show resolved Hide resolved
pi0
pi0 reviewed Oct 28, 2021
View reviewed changes
src/syntax.ts Outdated Show resolved Hide resolved
pi0
pi0 reviewed Oct 28, 2021
View reviewed changes
src/utils.ts Outdated Show resolved Hide resolved
@danielroe danielroe requested a review from pi0 October 28, 2021 13:32
@danielroe danielroe mentioned this pull request Oct 28, 2021
Merged
@pi0 pi0 merged commit 0cfa4d9 into main Oct 28, 2021
@pi0 pi0 deleted the feat/builtin-check branch October 28, 2021 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pi0 pi0 Awaiting requested review from pi0

Assignees

@danielroe danielroe

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@danielroe @pi0