Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: findTypeImports for finding type imports #163

Merged
merged 8 commits into from
Jun 19, 2023
Merged

Conversation

peterroe
Copy link
Contributor

@peterroe peterroe commented Apr 8, 2023

👀

@codecov
Copy link

codecov bot commented Apr 8, 2023

Codecov Report

Merging #163 (8c01d99) into main (f0b120b) will increase coverage by 1.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #163      +/-   ##
==========================================
+ Coverage   85.89%   86.90%   +1.01%     
==========================================
  Files           8        8              
  Lines         865      932      +67     
  Branches      134      148      +14     
==========================================
+ Hits          743      810      +67     
  Misses        122      122              
Impacted Files Coverage Δ
src/_utils.ts 98.48% <100.00%> (+0.70%) ⬆️
src/analyze.ts 97.97% <100.00%> (+0.25%) ⬆️
src/utils.ts 85.50% <100.00%> (+0.21%) ⬆️

Copy link
Member

@danielroe danielroe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! There are, I think, a couple of opportunities to de-duplicate code, however, such as L142-144 and L161-174, which are identical (at first glance) to parseStaticImports.

@peterroe
Copy link
Contributor Author

😊Thank you for the reminder. I have possibly extracted the same code from parseStaticImports and parseTypeImports into utils . Looking forward to your reply!

@pi0 pi0 self-requested a review June 19, 2023 12:26
@pi0 pi0 merged commit acae578 into unjs:main Jun 19, 2023
@pi0
Copy link
Member

pi0 commented Jun 19, 2023

Thanks ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants