Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support iis server preset #1436

Merged
merged 6 commits into from
Jul 15, 2023
Merged

feat: support iis server preset #1436

merged 6 commits into from
Jul 15, 2023

Conversation

antony-k1208
Copy link
Contributor

@antony-k1208 antony-k1208 commented Jul 15, 2023

πŸ”— Linked issue

Resolves #1427

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

@pi0 I tried to implement the needed preset for IIS deployments. Please let me know if there is anything I can improve πŸ™

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@nuxt-studio
Copy link
Contributor

nuxt-studio bot commented Jul 15, 2023

βœ… Live Preview ready!

Name Edit Preview Latest Commit
nitro Edit on Studio β†—οΈŽ View Live Preview 336278f

@pi0 pi0 changed the title feat: support iis server preset (#1427) feat: support iis server preset Jul 15, 2023
@pi0 pi0 changed the title feat: support iis server preset feat: support iis server preset Jul 15, 2023
Copy link
Member

@pi0 pi0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@codecov
Copy link

codecov bot commented Jul 15, 2023

Codecov Report

Merging #1436 (336278f) into main (976ec35) will decrease coverage by 0.70%.
The diff coverage is 25.74%.

@@            Coverage Diff             @@
##             main    #1436      +/-   ##
==========================================
- Coverage   76.86%   76.17%   -0.70%     
==========================================
  Files          71       73       +2     
  Lines        7336     7437     +101     
  Branches      728      728              
==========================================
+ Hits         5639     5665      +26     
- Misses       1696     1771      +75     
  Partials        1        1              
Impacted Files Coverage Ξ”
src/presets/iis-node.ts 18.46% <18.46%> (ΓΈ)
src/presets/iis.ts 35.29% <35.29%> (ΓΈ)
src/presets/index.ts 100.00% <100.00%> (ΓΈ)

@pi0 pi0 merged commit e87e2ba into nitrojs:main Jul 15, 2023
@pi0 pi0 mentioned this pull request Aug 4, 2023
This was referenced Aug 28, 2023
@tolgahanbeyazoglu
Copy link

tolgahanbeyazoglu commented Sep 8, 2023

@pi0 hello, when i put my nuxt js 3.7 project to IIS server, i get this error in recent updates Is there a different setting I should make?

Application has thrown an uncaught exception and is terminated:
RangeError [ERR_SOCKET_BAD_PORT]: options.port should be >= 0 and < 65536. Received \.\pipe\232894ee-5160-42b5-bf8a-808b2da18957.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support IIS server preset
4 participants