Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(rollup): use mlly as fallback resolver when externals disabled #948

Merged
merged 2 commits into from
Feb 15, 2023

Conversation

pi0
Copy link
Member

@pi0 pi0 commented Feb 15, 2023

πŸ”— Linked issue

resolves #947

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

When externals are disabled (workers like cf), we completely depend on rollup/node-resolve plugin which happens to fail resolving in pnpm monorepos. This PR adds mlly support as fallback which seems to supporting pnpm well and fixing resolving issue + a small fix for node+noExternals

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@codecov
Copy link

codecov bot commented Feb 15, 2023

Codecov Report

Merging #948 (36239a4) into main (db6e6c2) will decrease coverage by 0.17%.
The diff coverage is 26.08%.

@@            Coverage Diff             @@
##             main     #948      +/-   ##
==========================================
- Coverage   67.76%   67.59%   -0.17%     
==========================================
  Files          59       59              
  Lines        6009     6030      +21     
  Branches      676      679       +3     
==========================================
+ Hits         4072     4076       +4     
- Misses       1928     1945      +17     
  Partials        9        9              
Impacted Files Coverage Ξ”
src/rollup/config.ts 88.30% <26.08%> (-3.37%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@pi0 pi0 merged commit be1ac07 into main Feb 15, 2023
@pi0 pi0 deleted the fix/no-externals branch February 15, 2023 21:04
@timhanlon
Copy link
Contributor

I ran into the pnpm monorepo vs Cloudflare Workers thing yesterday, thanks for this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cannot build project in pnpm monorepo with externals disabled (cloudflare)
2 participants