-
Notifications
You must be signed in to change notification settings - Fork 507
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(cloudflare-pages): exclude assets from function call #965
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #965 +/- ##
==========================================
+ Coverage 67.59% 67.78% +0.19%
==========================================
Files 59 60 +1
Lines 6030 6128 +98
Branches 679 689 +10
==========================================
+ Hits 4076 4154 +78
- Misses 1945 1965 +20
Partials 9 9
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
This was referenced Feb 21, 2023
pi0
reviewed
Feb 21, 2023
pi0
changed the title
feat(cloudflare-pages): exclude assets from function call
fix(cloudflare-pages): exclude assets from function call
Feb 21, 2023
pi0
approved these changes
Feb 21, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks.
DataDrivenMD
added a commit
to Distal-Labs/elk
that referenced
this pull request
Feb 21, 2023
[X] Updated cloudflare pages deployment guide to reflect nitrojs/nitro#965 [X] Updated Github Actions workflow to use `NITRO_PRESET=cloudflare_pages`
This was referenced Feb 21, 2023
DataDrivenMD
added a commit
to Distal-Labs/elk
that referenced
this pull request
Mar 11, 2023
[X] Updated cloudflare pages deployment guide to reflect nitrojs/nitro#965 [X] Updated Github Actions workflow to use `NITRO_PRESET=cloudflare_pages`
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
π Linked issue
#497
β Type of change
π Description
We can generate a
_routes.json
file to prevent hits on assets directories from hitting the function at all. We might also be able to add individual assets that are outside of these directories to the json but this runs the risk of hitting the 100 rule limit. (Maybe we can allow extending the default config, suggested by @ColonelBundy.)π Checklist