Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: check process.cwd before calling it #147

Merged
merged 1 commit into from
Dec 12, 2023
Merged

Conversation

kraenhansen
Copy link
Contributor

@kraenhansen kraenhansen commented Nov 14, 2023

πŸ”— Linked issue

Fixes #148

❓ Type of change

  • πŸ“– Documentation (updates to the documentation, readme, or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

Some runtimes (like React Native) has a process global, but doesn't provide a cwd function. Instead of assuming the cwd function is available, just because the process global is, merging this PR will update the check to actually verify the process.cwd is a callable function before relying on it.

Resolves #148

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

Some runtimes (like React Native) has a `process` global, but doesn't provide a `cwd` function. Instead of assuming the `cwd` function is available, just because the `process` global is, merging this PR will update the check to actually verify the `process.cwd` is a callable function before relying on it.
@kraenhansen kraenhansen changed the title Check process.cwd before calling it fix: check process.cwd before calling it Nov 14, 2023
@pi0 pi0 merged commit 0bb67d4 into unjs:main Dec 12, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TypeError: process.cwd is not a function (it is undefined) on React Native
2 participants