Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: allow caching readPackageJSON and readTSConfig #47

Merged
merged 2 commits into from
Nov 14, 2022
Merged

feat: allow caching readPackageJSON and readTSConfig #47

merged 2 commits into from
Nov 14, 2022

Conversation

danielroe
Copy link
Member

No description provided.

@danielroe danielroe added the enhancement New feature or request label Sep 26, 2022
@danielroe danielroe requested a review from pi0 September 26, 2022 10:37
@danielroe danielroe self-assigned this Sep 26, 2022
@danielroe danielroe mentioned this pull request Sep 26, 2022
Merged
7 tasks
pi0
pi0 reviewed Sep 26, 2022
View reviewed changes
src/index.ts Outdated Show resolved Hide resolved
@pi0 pi0 changed the title perf: cache package.json + tsconfig.json results feat: allow caching readPackageJSON and readTSConfig Sep 26, 2022
@pi0
Copy link
Member

pi0 commented Sep 26, 2022

Alternative: We could also expose readCachedPackageJSON and readCachedTSConfig that enable cache for reading.

@pi0 pi0 merged commit ca127d0 into main Nov 14, 2022
@pi0 pi0 deleted the perf/cache-files branch November 14, 2022 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pi0 pi0 pi0 left review comments

Assignees

@danielroe danielroe

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@danielroe @pi0