Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(resolveUrl): decouple from $URL #186

Merged
merged 5 commits into from
Feb 5, 2024

Conversation

DaniAcu
Copy link
Contributor

@DaniAcu DaniAcu commented Nov 11, 2023

πŸ”— Linked issue

#36

❓ Type of change

  • πŸ“– Documentation (updates to the documentation, readme, or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

Using the utils to resolve the url but not using URL contructor

Resolves #36

We continue need to document the $URL

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

Copy link

codecov bot commented Feb 5, 2024

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (d283cf5) 95.27% compared to head (e4e93a8) 98.58%.
Report is 8 commits behind head on main.

Files Patch % Lines
src/utils.ts 91.66% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #186      +/-   ##
==========================================
+ Coverage   95.27%   98.58%   +3.31%     
==========================================
  Files           7        7              
  Lines         867      917      +50     
  Branches      187      212      +25     
==========================================
+ Hits          826      904      +78     
+ Misses         41       13      -28     

β˜” View full report in Codecov by Sentry.
πŸ“’ Have feedback on the report? Share it here.

@pi0 pi0 changed the title feat: decouple resolveUrl from URL refactor(resolveUrl): decouple from $URL Feb 5, 2024
Copy link
Member

@pi0 pi0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks ❀️

@pi0 pi0 merged commit 3b66d62 into unjs:main Feb 5, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

decouple resolveURL from $URL
2 participants