-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: polyfill node:inspector
and node:inspector/promises
#207
Conversation
83047a4
to
550bacd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 to @pi0's comments. otherwise looks good to me.
β¦romises' modules Replaces the current auto-mocking of 'inspector' to support destructured ESM imports and allow for functional polyfill coverage in the future.
550bacd
to
fba8af7
Compare
node:inspector
and node:inspector/promises
node:inspector
and node:inspector/promises
// `node:inspector` and `node:inspector/promises` share the same implementation with only Session being in the promises module: | ||
// https://github.com/nodejs/node/blob/main/lib/inspector/promises.js | ||
export const Session: typeof inspector.Session = | ||
mock.__createMock__("inspector.Session"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Session.post
's promise won't be resolved (it is not only limited to here. made tracker: #212)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
π Linked issue
β Type of change
π Description
π Checklist
Adds a polyfill for the
node:inspector
andnode:inspector/promises
modules. Also creates a general purpose mock for theDisposable
type.