feat: polyfill node:inspector and node:inspector/promises
#207
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jculvey
force-pushed
the
polyfill-inspector
branch
from
83047a4
to
550bacd
Compare
pi0
reviewed
May 27, 2024
pi0
reviewed
May 27, 2024
…romises' modules Replaces the current auto-mocking of 'inspector' to support destructured ESM imports and allow for functional polyfill coverage in the future.
jculvey
force-pushed
the
polyfill-inspector
branch
from
550bacd
to
fba8af7
Compare
pi0
changed the title
node:inspector and node:inspector/promisesnode:inspector and node:inspector/promises
pi0
reviewed
May 29, 2024
pi0
reviewed
May 29, 2024
| // `node:inspector` and `node:inspector/promises` share the same implementation with only Session being in the promises module: | ||
| // https://github.com/nodejs/node/blob/main/lib/inspector/promises.js | ||
| export const Session: typeof inspector.Session = | ||
| mock.__createMock__("inspector.Session"); |
There was a problem hiding this comment.
Session.post's promise won't be resolved (it is not only limited to here. made tracker: #212)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔗 Linked issue
❓ Type of change
📚 Description
📝 Checklist
Adds a polyfill for the
node:inspectorandnode:inspector/promisesmodules. Also creates a general purpose mock for theDisposabletype.