Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cloudflare): revert sys alias change #344

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

anonrig
Copy link
Contributor

@anonrig anonrig commented Oct 27, 2024

Partially reverts #343

@anonrig anonrig requested review from vicb and jasnell October 27, 2024 00:04
@anonrig anonrig requested a review from a team as a code owner October 27, 2024 00:04
Copy link
Contributor

@vicb vicb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the updates, see my inline comments

@@ -51,6 +51,11 @@ const cloudflarePreset: Preset = {
]),
),

// The `node:sys` module is just a deprecated alias for `node:util`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove l29 as well.
Thanks


// --- node:path

export const path_implements = {
Copy link
Contributor

@vicb vicb Oct 27, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think what I tested and was not working was delimiter and sep

See cloudflare/workerd#3012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants